Harden registry URL handling#153
Merged
JSONbored merged 1 commit intoJun 19, 2026
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
metagraphed-ui | 9a2e2c1 | Commit Preview URL Branch Preview URL |
Jun 19 2026, 08:58 AM |
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
40296d0 to
9a2e2c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
safeExternalUrlinsrc/components/metagraphed/external-link.tsxto reject URLs with embedded credentials by checkingurl.usernameandurl.passwordin addition to existing protocol and private-host checks.schema.urlinsrc/routes/schemas.tsxso the UI only requests the trusted API diff endpoint and does not issue arbitrary client-side GETs to backend-provided URLs.ExternalLink/safeExternalUrlhelper so unsafe links are rendered as non-clickable spans instead of anchors.Testing
rg "fetch(schema.url)|url.username|url.password|safeExternalUrl"which confirmed the changes are present insrc/components/metagraphed/external-link.tsxandsrc/routes/schemas.tsx(success).npm run typecheckwhich failed due to missing installed dependencies and a missingvite/clienttype definition in this environment (failed).npm ciwhich failed on a peer-dependency conflict and withnpm ci --legacy-peer-depswhich stalled/timeouted in this environment (failed/partial).Codex Task