Skip to content

refactor: centralize interrupt request helper binding#480

Merged
liujuanjuan1984 merged 2 commits intomainfrom
issue-438-evaluation
May 6, 2026
Merged

refactor: centralize interrupt request helper binding#480
liujuanjuan1984 merged 2 commits intomainfrom
issue-438-evaluation

Conversation

@liujuanjuan1984
Copy link
Copy Markdown
Collaborator

@liujuanjuan1984 liujuanjuan1984 commented May 6, 2026

概要

  • 集中收口 interrupt request helper 的动态绑定,把 stream_runtimeinterrupt_callbacks 的分散 getattr/callable 探测下沉到单一 helper
  • 主路径优先使用 resolve_interrupt_request() 的显式语义,同时保留对历史 resolve_interrupt_session() session-only client 的兼容
  • 统一测试替身的 interrupt helper surface,并补充 legacy callback 兼容回归测试
  • 本次刻意不扩展到 state_store.initialize()task_store.initialize() 的其它动态派发清理

验证

  • bash ./scripts/doctor.sh

Closes #438

@liujuanjuan1984
Copy link
Copy Markdown
Collaborator Author

独立复审结论:未发现需要阻塞合并的问题。

补充判断如下:

  • 本 PR 的改动范围与 #438 当前收敛后的实施边界一致,重点聚焦 interrupt helper 动态派发,不再扩展到 state_store.initialize()task_store.initialize(),范围控制合理。
  • 新增的集中 helper 把 stream_runtimeinterrupt_callbacks 中分散的 getattr/callable 探测收口到单点,同时保留对历史 resolve_interrupt_session() session-only client 的兼容,方案比继续在热路径散落动态探测更稳健。
  • 测试替身已经统一到显式 helper surface,并补上了 legacy callback 兼容回归;bash ./scripts/doctor.sh 也已通过,验证覆盖充分。
  • 关联关系方面,Closes #438 准确;当前没有必须一并标注的其它相关 open issues,保持现状即可。

@liujuanjuan1984 liujuanjuan1984 merged commit 8ea6a26 into main May 6, 2026
3 checks passed
@liujuanjuan1984 liujuanjuan1984 deleted the issue-438-evaluation branch May 6, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Priority: Med] [Refactor] 收敛 JSON-RPC 与 execution 的动态 hook 派发

1 participant