refactor: isolate test settings and narrow local compatibility#475
Merged
liujuanjuan1984 merged 5 commits intomainfrom May 6, 2026
Merged
refactor: isolate test settings and narrow local compatibility#475liujuanjuan1984 merged 5 commits intomainfrom
liujuanjuan1984 merged 5 commits intomainfrom
Conversation
Collaborator
Author
|
独立审查结论:本 PR 未发现阻塞性问题,可以进入正常评审流程。 代码变动审查:
实现质量审查:
PR 标题与描述审查:
Issue 关系审查:
|
Collaborator
Author
|
补充同步:基于当前分支继续收口了“本仓向
独立复审结论不变:当前 PR 仍未发现阻塞性问题,且实现比上一版更贴近可复用的测试 support 组织方式。 |
Collaborator
Author
|
补充同步:根据进一步审查,已去掉本仓内部不必要的“兼容旧导入路径”做法。
这次调整更符合你的要求,也更符合测试基础设施应有的边界:测试专用能力留在 |
Collaborator
Author
|
基于当前分支再次独立审查后,这个 PR 的最终收敛范围如下:
审查结论:
验证:
|
Collaborator
Author
|
补充一处边界调整:保留了 调整原因:
验证:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
摘要
tests/support/settings.py中引入仅保留init_settings的隔离 settings helper,避免make_settings()继续读取 ambient environment、.env与 secrets sourcetests.support.settings导入make_settings,移除tests.support.helpers上不必要的 helper re-exporttests/config/test_settings.pyquery.*双入口;收紧 client transport 宽松别名;补充当前a2a-sdkcore JSON-RPC 方法集合锁定测试设计判断
#474仅修复测试 settings 污染问题,不调整生产Settings的装配逻辑#476将本仓自定义兼容面收敛到更明确的契约:provider-private session query 只保留单一顶层形状,不再兼容本仓自己定义出的双入口a2a-sdk版本,但通过完整集合测试把它变成显式升级审查点json_rpc、httpjson、http+json+这类无必要别名#439与本次同属tests/support/helpers.py域,但目标是宽接口 fake client 拆分,属于后续结构性重构;本 PR 不包含该范围验证
bash ./scripts/doctor.shIssues
Closes #474
Closes #476
Related #439