Add object locking and retention support to Bucket CRD#133
Open
mr-083 wants to merge 1 commit intoInseeFrLab:mainfrom
Open
Add object locking and retention support to Bucket CRD#133mr-083 wants to merge 1 commit intoInseeFrLab:mainfrom
mr-083 wants to merge 1 commit intoInseeFrLab:mainfrom
Conversation
Add objectLocking and retention fields to BucketSpec, enabling
declarative immutable bucket creation via Kubernetes CRDs.
- BucketSpec: add objectLocking (bool, immutable) and retention
(mode: governance|compliance, days: uint) fields
- S3Client: CreateBucket now accepts objectLocking parameter,
new SetBucketRetention method for default retention config
- Controller: pass objectLocking to MakeBucket, apply retention
after bucket creation when both objectLocking and retention are set
- CRDs: regenerated with kubebuilder validation markers
- Tests: updated mocks and test utils for new CreateBucket signature
Example usage:
apiVersion: s3.onyxia.sh/v1alpha1
kind: Bucket
spec:
name: backup-immutable
objectLocking: true
retention:
mode: governance
days: 90
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
objectLocking(bool, immutable) andretention(mode + days) fields toBucketSpecCreateBucketpassesObjectLocking: truetominio.MakeBucketOptionswhen enabledSetBucketRetentionsets default governance/compliance retention after bucket creationExample
Test plan
go build ./...passesgo test ./internal/controller/bucket/ -vpassesmc retention infoconfirmsGOVERNANCEconfigured for90DAYS