Refactor/magma gestion#463
Open
GtanSndil wants to merge 73 commits intorefactor/refactoring_magma_traditional_in_new_magmafrom
Open
Refactor/magma gestion#463GtanSndil wants to merge 73 commits intorefactor/refactoring_magma_traditional_in_new_magmafrom
GtanSndil wants to merge 73 commits intorefactor/refactoring_magma_traditional_in_new_magmafrom
Conversation
…tional_in_new_magma' into refactor/test_ia # Conflicts: # magma-commons-infra/src/main/java/fr/insee/rmes/magma/queryexecutor/QueryExecutor.java # magma-diffusion-impl/pom.xml # magma-diffusion-impl/src/main/java/fr/insee/rmes/magma/diffusion/api/requestprocessor/RequestProcessor.java # magma-diffusion-impl/src/main/java/fr/insee/rmes/magma/diffusion/queries/parameters/ConceptsRequestParametizer.java # magma-gestion-impl/src/main/java/fr/insee/rmes/magma/gestion/old/controller/StructuresResources.java # pom.xml
…nto refactor/test_ia
FBibonne
reviewed
Apr 22, 2026
Member
FBibonne
left a comment
FBibonne
left a comment
There was a problem hiding this comment.
- Pour loguer les propriétés au démarrage, ne pas utiliser les classes PropertiesLogger (les supprimzer) mais ajouter la dépendance io.github.fbibonne:boot-properties-logger-starter:2.3.0 dans les pom des projets web (version dans les dependecymanagement du parent) en valorisant la propriété properties.logger.prefix-for-properties (comme dans Bauhaus back)
| <packaging>pom</packaging> | ||
| <name>Implementation of the RMéS metadata API</name> | ||
| <dependencies> | ||
| <dependency> |
Member
There was a problem hiding this comment.
Il ne faut pas mettre de dépendances dans le pom parent
| </plugin> | ||
| </plugins> | ||
| </pluginManagement> | ||
| <plugins> |
Member
There was a problem hiding this comment.
Pourquoi java 19 ?
La configuration de la version de java est faite au niveau des properties
| <properties> | ||
| <java.version>21</java.version> | ||
| <maven.compiler.release>${java.version}</maven.compiler.release> | ||
| <maven.compiler.source>${java.version}</maven.compiler.source> |
Member
There was a problem hiding this comment.
Si on maven.compiler.release , il me semble que source et target sont inutiles
| email: dr59-sinl-equipe-maintenance-rmes@insee.fr | ||
| version: 1.4.11 | ||
| servers: | ||
| - url: https://api-rmes-gestion.insee.fr |
Member
There was a problem hiding this comment.
Url interne à ne pas mettre dans un projet opne source
| <dependency> | ||
| <groupId>org.testcontainers</groupId> | ||
| <artifactId>testcontainers</artifactId> | ||
| <version>1.21.3</version> |
Member
There was a problem hiding this comment.
scope test + version gérées dans le dependencymanagement du pom parent avec variabilisation de la version
| @@ -0,0 +1,47 @@ | |||
| //package fr.insee.rmes.magma.gestion.configuration; | |||
| <dependency> | ||
| <groupId>org.springframework</groupId> | ||
| <artifactId>spring-core</artifactId> | ||
| <scope>compile</scope> |
| <dependency> | ||
| <groupId>org.springframework</groupId> | ||
| <artifactId>spring-context</artifactId> | ||
| <scope>compile</scope> |
|
|
||
| @org.springframework.context.annotation.Configuration | ||
| @Slf4j | ||
| @ServletComponentScan |
Member
There was a problem hiding this comment.
Mettre l'annotation dans magama-diffusion-impl : c'est pour LogRequestFilter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.