You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The resolveColorExpression function returns .clear for non-T1 tokens (T2/T3) that have direct color values instead of token references. This effectively discards valid color data if a semantic or component token defines a color directly rather than referencing a primitive token. The logic should handle direct values for all token tiers or explicitly warn about this constraint.
The custom parser performs JSON.parse(contents) without a try-catch block. If a token file contains malformed JSON, this will throw an unhandled exception with no indication of which file caused the failure, making debugging difficult in large token sets.
The cleanSegment function strips all non-alphanumeric characters (except dashes) before converting to camelCase. This can cause naming collisions if token paths differ only by special characters (e.g., color-red and color_red both become colorred), potentially leading to duplicate Swift property names or incorrect references.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add Style dictionary context and model to export tokens to swift (SwiftUI)