feat: Auto-fill URL field when adding a link from selected text in the editor#2865
Closed
amariaux wants to merge 86 commits intorich-editorfrom
Closed
feat: Auto-fill URL field when adding a link from selected text in the editor#2865amariaux wants to merge 86 commits intorich-editorfrom
amariaux wants to merge 86 commits intorich-editorfrom
Conversation
# Conflicts: # app/src/main/java/com/infomaniak/mail/ui/main/thread/MessageDisplayWebViewClient.kt # app/src/main/java/com/infomaniak/mail/ui/main/thread/MessageWebViewClient.kt # app/src/main/java/com/infomaniak/mail/ui/main/thread/webViewClient/MessageWebViewClient.kt # app/src/main/java/com/infomaniak/mail/utils/extensions/Extensions.kt
…nt is already sanitized
… and remove empty spaces
PR Reviewer Guide 🔍(Review updated until commit e51d86a)Here are some key observations to aid the review process:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Persistent review updated to latest commit e51d86a |
|
solrubado
force-pushed
the
rich-editor
branch
2 times, most recently
from
93324c0 to
6d117ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on : Infomaniak/android-rich-html-editor#55
Depends on : #2811