-
Notifications
You must be signed in to change notification settings - Fork 8
feat: support partial writes #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alespour
wants to merge
11
commits into
main
Choose a base branch
from
feat/partial-writes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
c545973
feat: support partial writes
alespour 68c8163
fix: harden error parser
alespour 85b55c0
feat: add typed exception
alespour f07af4e
docs: update CHANGELOG
alespour ad34d1a
test: more coverage
alespour f820e87
test: more coverage
alespour b18e1e8
test: more coverage
alespour ad6ba70
fix: strict partial error prasing with simple fallback
alespour d0d5dd9
fix: line length linter complaint
alespour 32ae8bb
test: more coverage
alespour 8bc0938
fix: annotation
alespour File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
110 changes: 110 additions & 0 deletions
110
src/main/java/com/influxdb/v3/client/InfluxDBPartialWriteException.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,110 @@ | ||
| /* | ||
| * The MIT License | ||
| * | ||
| * Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| * of this software and associated documentation files (the "Software"), to deal | ||
| * in the Software without restriction, including without limitation the rights | ||
| * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| * copies of the Software, and to permit persons to whom the Software is | ||
| * furnished to do so, subject to the following conditions: | ||
| * | ||
| * The above copyright notice and this permission notice shall be included in | ||
| * all copies or substantial portions of the Software. | ||
| * | ||
| * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| * THE SOFTWARE. | ||
| */ | ||
| package com.influxdb.v3.client; | ||
|
|
||
| import java.net.http.HttpHeaders; | ||
| import java.util.List; | ||
| import javax.annotation.Nonnull; | ||
| import javax.annotation.Nullable; | ||
|
|
||
| /** | ||
| * HTTP exception for partial write errors returned by InfluxDB 3 write endpoint. | ||
| * Contains parsed line-level write errors so callers can decide how to handle failed lines. | ||
| */ | ||
| public class InfluxDBPartialWriteException extends InfluxDBApiHttpException { | ||
|
|
||
| private final List<LineError> lineErrors; | ||
|
|
||
| /** | ||
| * Construct a new InfluxDBPartialWriteException. | ||
| * | ||
| * @param message detail message | ||
| * @param headers response headers | ||
| * @param statusCode response status code | ||
| * @param lineErrors line-level errors parsed from response body | ||
| */ | ||
| public InfluxDBPartialWriteException( | ||
| @Nullable final String message, | ||
| @Nullable final HttpHeaders headers, | ||
| final int statusCode, | ||
| @Nonnull final List<LineError> lineErrors) { | ||
| super(message, headers, statusCode); | ||
| this.lineErrors = List.copyOf(lineErrors); | ||
| } | ||
|
|
||
| /** | ||
| * Line-level write errors. | ||
| * | ||
| * @return immutable list of line errors | ||
| */ | ||
| @Nonnull | ||
| public List<LineError> lineErrors() { | ||
| return lineErrors; | ||
| } | ||
|
|
||
| /** | ||
| * Represents one failed line from a partial write response. | ||
| */ | ||
| public static final class LineError { | ||
|
|
||
| private final Integer lineNumber; | ||
| private final String errorMessage; | ||
| private final String originalLine; | ||
|
|
||
| /** | ||
| * @param lineNumber line number in the write payload; may be null if not provided by server | ||
| * @param errorMessage line-level error message | ||
| * @param originalLine original line protocol row; may be null if not provided by server | ||
| */ | ||
| public LineError(@Nullable final Integer lineNumber, | ||
| @Nonnull final String errorMessage, | ||
| @Nullable final String originalLine) { | ||
| this.lineNumber = lineNumber; | ||
| this.errorMessage = errorMessage; | ||
| this.originalLine = originalLine; | ||
| } | ||
|
|
||
| /** | ||
| * @return line number or null if server didn't provide it | ||
| */ | ||
| @Nullable | ||
| public Integer lineNumber() { | ||
| return lineNumber; | ||
| } | ||
|
|
||
| /** | ||
| * @return line-level error message | ||
| */ | ||
| @Nonnull | ||
| public String errorMessage() { | ||
| return errorMessage; | ||
| } | ||
|
|
||
| /** | ||
| * @return original line protocol row or null if server didn't provide it | ||
| */ | ||
| @Nullable | ||
| public String originalLine() { | ||
| return originalLine; | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.