[DEV-15064] Fixes to allow creating on-prem test infra#570
[DEV-15064] Fixes to allow creating on-prem test infra#570NathanOkolita merged 23 commits intomainfrom
Conversation
…dependency on nfs storage class existance.
…dependency on nfs storage class existance. Try 2
…dependency on nfs storage class existance. Try 3
…dependency on nfs storage class existance. Try 4
…dependency on nfs storage class existance. Try 5
… ensure in indico namespace and not default.
… ensure in indico namespace and not default.
…or on-prem-backing
| type = string | ||
| default = "pgha1" | ||
| description = "Name of the Crunchy Postgres instance set." | ||
| } |
There was a problem hiding this comment.
Default instance name changed from pgha2 to pgha1
High Severity
The new crunchy_instance_name variable defaults to "pgha1", but it replaces the previously hardcoded value "pgha2" in the else branch of crunchy_instances_values. This else branch is used for all standard (non-on-prem-local) deployments, including production. Existing deployments that don't explicitly set this variable will see their Crunchy PostgreSQL instance set name change from pgha2 to pgha1, which could trigger the operator to destroy and recreate the StatefulSet, risking data loss or downtime.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit 50a2785. Configure here.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2af9184. Configure here.


Note
Medium Risk
Changes how on-prem test environments provision Postgres/RabbitMQ storage and pgBackRest backups, which can affect data persistence and recovery behavior. Also enables additional operators in on-prem mode, increasing the surface area of infra changes during deploys.
Overview
Improves support for on-prem test deployments by making Postgres storage configurable between local hostPath PVs and NFS-backed dynamic provisioning via new
on_prem_volume_backing.Updates the Crunchy Postgres Helm overrides to support a configurable instance-set name (
crunchy_instance_name) and to switchpgBackRestfrom S3-backed repos to a PVC-backed repo whenon_prem_testis enabled.Hardens the on-prem NFS setup by adding an exports ConfigMap, initializing required subdirectories, updating the NFS server image/pull secrets, and increasing the backing PVC size; additionally wires on-prem defaults so core operators (
crunchy-pgo,migrations-operator,rabbitmq-operator,dragonfly-operator) can be enabled for on-prem test runs and sets RabbitMQ persistence to usenfs-clientwhen applicable.Reviewed by Cursor Bugbot for commit 2af9184. Bugbot is set up for automated code reviews on this repo. Configure here.