Skip to content

[DEV-15064] Fixes to allow creating on-prem test infra#570

Merged
NathanOkolita merged 23 commits intomainfrom
dev-15064
Apr 17, 2026
Merged

[DEV-15064] Fixes to allow creating on-prem test infra#570
NathanOkolita merged 23 commits intomainfrom
dev-15064

Conversation

@NathanOkolita
Copy link
Copy Markdown
Contributor

@NathanOkolita NathanOkolita commented Apr 17, 2026

Note

Medium Risk
Changes how on-prem test environments provision Postgres/RabbitMQ storage and pgBackRest backups, which can affect data persistence and recovery behavior. Also enables additional operators in on-prem mode, increasing the surface area of infra changes during deploys.

Overview
Improves support for on-prem test deployments by making Postgres storage configurable between local hostPath PVs and NFS-backed dynamic provisioning via new on_prem_volume_backing.

Updates the Crunchy Postgres Helm overrides to support a configurable instance-set name (crunchy_instance_name) and to switch pgBackRest from S3-backed repos to a PVC-backed repo when on_prem_test is enabled.

Hardens the on-prem NFS setup by adding an exports ConfigMap, initializing required subdirectories, updating the NFS server image/pull secrets, and increasing the backing PVC size; additionally wires on-prem defaults so core operators (crunchy-pgo, migrations-operator, rabbitmq-operator, dragonfly-operator) can be enabled for on-prem test runs and sets RabbitMQ persistence to use nfs-client when applicable.

Reviewed by Cursor Bugbot for commit 2af9184. Bugbot is set up for automated code reviews on this repo. Configure here.

…dependency on nfs storage class existance. Try 2
…dependency on nfs storage class existance. Try 3
…dependency on nfs storage class existance. Try 4
…dependency on nfs storage class existance. Try 5
… ensure in indico namespace and not default.
… ensure in indico namespace and not default.
Comment thread application.tf Outdated
Comment thread application.tf Outdated
Comment thread application.tf
Comment thread on_prem_test.tf
Comment thread application.tf Outdated
Comment thread variables.tf
type = string
default = "pgha1"
description = "Name of the Crunchy Postgres instance set."
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default instance name changed from pgha2 to pgha1

High Severity

The new crunchy_instance_name variable defaults to "pgha1", but it replaces the previously hardcoded value "pgha2" in the else branch of crunchy_instances_values. This else branch is used for all standard (non-on-prem-local) deployments, including production. Existing deployments that don't explicitly set this variable will see their Crunchy PostgreSQL instance set name change from pgha2 to pgha1, which could trigger the operator to destroy and recreate the StatefulSet, risking data loss or downtime.

Additional Locations (2)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 50a2785. Configure here.

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2af9184. Configure here.

Comment thread application.tf
@NathanOkolita NathanOkolita merged commit 1ff7094 into main Apr 17, 2026
19 of 20 checks passed
@NathanOkolita NathanOkolita deleted the dev-15064 branch April 17, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants