Open
Conversation
We only have one owner, and `unique_ptr` makes that clear. I only spotted this after removing a `boost/format.hpp` include from another header. These two files weren't including `boost/shared_ptr.hpp` themselves, and were instead getting it transitively from the other header.
murraystevenson
approved these changes
Feb 13, 2026
Collaborator
murraystevenson
left a comment
murraystevenson
left a comment
There was a problem hiding this comment.
Thanks John! Changes look good from my perspective. Great to see we're almost free of boost::format()...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a couple of strays that escaped the purge in #1514, and a couple of associated issues. I found these by removing support for
boost::format()from the MessageHandler class. @ivanimanishi, if that is a step too far then just let us know and we can drop that commit from this PR. The single remainingboost::format()usage is now inFileSequence::fileNameTemplate(), which is a protected method. There are no derived classes that can make use of it in Cortex or Gaffer, so I wonder if IE has something internally using it, or if it should have been private all along. If the latter, then I'll remove it too.