WIP - IMAP-Lo requested tweaks#3293
Draft
vineetbansal wants to merge 2 commits into
Draft
Conversation
…t 2 constants - STAR_END_BINS_TO_EXCLUDE, STAR_MIN_COUNT_THRESHOLD. lo_angle_offset gone
…state at its start.
tmplummer
reviewed
Jun 9, 2026
| STAR_BIN_OFFSET_BY_SYNC: ClassVar[dict[str | None, float]] = { | ||
| "DS": 0.5, # star sync disabled (pre FSW 4.8) | ||
| "EN": 0.0, # star sync enabled (FSW 4.8+) | ||
| None: 0.5, # default value |
Contributor
There was a problem hiding this comment.
Are there instances where the value is not either "DS", or "EN". I'm wondering if this silently handling a None value is a bad thing to do. It seems like a major problem that should fail loudly if the state is not one of the two options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3289, #3270
get_star_bin_offsetguided bySTAR_BIN_OFFSET_BY_SYNCdictSTAR_END_BINS_TO_EXCLUDE,STAR_MIN_COUNT_THRESHOLDlo_angle_offsetgone, per issue Lo L1b prostar - remove two degree offset #3270