fix(codice): mark Lo RGFO/NSO vars as support_data#3292
Merged
tech3371 merged 1 commit intoJun 9, 2026
Merged
Conversation
Issue IMAP-Science-Operations-Center#2798 called out that these CoDICE Lo variables are not science data and should not be written with VAR_TYPE=data: rgfo_half_spin\nrgfo_spin_sector\nrgfo_esa_step\nnso_half_spin\nnso_spin_sector\nnso_esa_step Update the L1A attribute definitions to mark those variables as support_data, which also fixes the Lo direct-event L2 file for the NSO variables that are carried forward from L1A. Add written-CDF regression checks for both the Lo direct-event L1A file and the Lo direct-event L2 file.
tech3371
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rgfo_*andnso_*telemetry state variables assupport_datainstead ofdataWhy
Issue #2798 called out that these variables are supporting telemetry state, not science data. They were still defined with
VAR_TYPE = datain the CoDICE L1A attrs YAML, which also affected the Lo direct-events metadata carried forward into L2.Validation
./.venv/bin/python -m pytest -q imap_processing/tests/codice/test_codice_l1a.py./.venv/bin/python -m pytest -q imap_processing/tests/codice/test_codice_l2.pyFixes #2798