Skip to content

T&A 46507: Corrects sorting of questions by question type#11199

Open
matheuszych wants to merge 1 commit intoILIAS-eLearning:release_11from
matheuszych:ta/46507
Open

T&A 46507: Corrects sorting of questions by question type#11199
matheuszych wants to merge 1 commit intoILIAS-eLearning:release_11from
matheuszych:ta/46507

Conversation

@matheuszych
Copy link
Contributor

https://mantis.ilias.de/view.php?id=46507

Aims to fix correct sorting of questions by question type.
@thojou

@matheuszych
Copy link
Contributor Author

Hello @kergomard ,

we would like to get your opinion on this. Currently we achieved the wanted behavior by translating and sorting the entries directly on the database level. Is this a viable solution or should we rather do it after the results have been queried in PHP?

Best regards
@matheuszych

@dsstrassner dsstrassner self-assigned this Feb 27, 2026
@dsstrassner dsstrassner added bugfix php Pull requests that update Php code labels Feb 27, 2026
@kergomard
Copy link
Contributor

Hi @matheuszych

Ok, I would be all in favor of ordering on the database, but here there is a big "but": We MUST never access tables that do not belong to us. The database in my world does never belong to the surface of a component. We can thus not implement the ordering in this way.

And then a small sidenote: Please do not call the column "ttype". It is completely unclear what "t" stands for. The columns should be called "question_type", if I'm not getting this wrong. I would kindly ask you to always be verbose on naming and so to not use abbreviations.

Thanks and best,
@kergomard

@matheuszych
Copy link
Contributor Author

Hello @kergomard ,
thank you for your feedback. I adjusted everything so now when the entries are sorted by question type, it happens in PHP. All other things are still sorted directly in the database.

Best regards
@matheuszych

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix php Pull requests that update Php code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants