-
Notifications
You must be signed in to change notification settings - Fork 50
Update legacy sample pages #990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Replace old links to uid2-web-integrations examples with new sample site links from samples.uidapi.com. Updated both sdk-ref-javascript.md and sdk-ref-javascript-v3.md to point to: - Client-Side JS SDK integration example - Client-Server JS SDK integration example - Reference to full Integration Samples and Tools page Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
- Updated sample titles to include "SDK v4 for JavaScript" - Removed redundant link to Integration Samples and Tools page Co-authored-by: Cursor <cursoragent@cursor.com>
The examples folder was removed from uid2-web-integrations repo. Co-authored-by: Cursor <cursoragent@cursor.com>
| For an [example application](https://example-jssdk-integ.uidapi.com/), with associated documentation, see the [UID2 SDK Integration Example](https://github.com/IABTechLab/uid2-web-integrations/tree/main/examples/js-sdk). | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also removed in the v2 section (which only exist in UID2) which is a legacy version
| - [Code and docs](https://github.com/IABTechLab/uid2-web-integrations/tree/main/examples/google-secure-signals-integration/with_sdk_v3) | ||
| - Running site: [Client-Side UID2 SDK Integration Example](https://secure-signals-client-server-integ.uidapi.com/) | ||
| - The example of JavaScript client-side integration: [Code](https://github.com/IABTechLab/uid2-web-integrations/tree/main/examples/cstg) and running site ([Client-Side Integration Example, UID2 JavaScript SDK](https://cstg-integ.uidapi.com/)). | ||
| - Client-Side Integration Using UID2 SDK v4 for JavaScript: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it actually use v4? Do we need to say the version? Just checking.
| - Client-Side Integration Using UID2 SDK v4 for JavaScript: | ||
| - [Code](https://github.com/IABTechLab/uid2-examples/tree/main/web-integrations/javascript-sdk/client-side) | ||
| - Running site: [Client-Side UID2 Integration Example](https://js-client-side.samples.uidapi.com/) | ||
| - Client-Server Integration Using UID2 SDK v4 for JavaScript: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. Not sure we need to say v4 but your call.
| - The example of JavaScript client-side integration: [Code](https://github.com/IABTechLab/uid2-web-integrations/tree/main/examples/cstg) and running site ([Client-Side Integration Example, UID2 JavaScript SDK](https://cstg-integ.uidapi.com/)). | ||
| - Client-Side Integration Using UID2 SDK v4 for JavaScript: | ||
| - [Code](https://github.com/IABTechLab/uid2-examples/tree/main/web-integrations/javascript-sdk/client-side) | ||
| - Running site: [Client-Side UID2 Integration Example](https://js-client-side.samples.uidapi.com/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the doc per se, but your linked site https://js-client-side.samples.integ.euid.eu/ itself has a broken link in it, to the integration guide. URL looks mostly OK... perhaps you're missing the protocol?
| - Running site: [Client-Side UID2 Integration Example](https://js-client-side.samples.uidapi.com/) | ||
| - Client-Server Integration Using UID2 SDK v4 for JavaScript: | ||
| - [Code](https://github.com/IABTechLab/uid2-examples/tree/main/web-integrations/javascript-sdk/client-server) | ||
| - Running site: [Client-Server UID2 Integration Example](https://js-client-server.samples.uidapi.com/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again: Your site https://js-client-server.samples.integ.euid.eu/ has two broken doc links. The link to the Git repo works.
genwhittTTD
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly great. Few comments, including WRT the linked sites. Not sure if they are still draft perhaps.
No description provided.