Open
Conversation
opaliukh
reviewed
Apr 16, 2026
| import com.hubspot.slack.client.models.blocks.elements.BlockElement; | ||
|
|
||
| @JsonTypeInfo(use = JsonTypeInfo.Id.NAME, property = "type") | ||
| @JsonSubTypes( |
Contributor
There was a problem hiding this comment.
Should we also include rich_text_preformatted and rich_text_quote? What will happen if we receive a type that we do not support (if that’s somehow possible)? I am cautious about introducing logic-breaking changes.
opaliukh
reviewed
Apr 16, 2026
opaliukh
reviewed
Apr 16, 2026
…e interface structure.
Contributor
Author
|
@opaliukh Fixed all comments. |
opaliukh
reviewed
Apr 16, 2026
| @Value.Parameter | ||
| RichTextListStyle getStyle(); | ||
|
|
||
| Optional<Integer> getIntend(); |
Contributor
There was a problem hiding this comment.
Suggested change
| Optional<Integer> getIntend(); | |
| Optional<Integer> getIndent(); |
opaliukh
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new block types: TaskCardBlock, MarkdownBlock and it's underlying structure to the models.