fix: treat extra files in batch input folder as warning, not error#552
Open
octo-patch wants to merge 1 commit intoHuanshere:mainfrom
Open
fix: treat extra files in batch input folder as warning, not error#552octo-patch wants to merge 1 commit intoHuanshere:mainfrom
octo-patch wants to merge 1 commit intoHuanshere:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #518
Problem
When the
batch/inputfolder contains more files than are listed intasks_setting.xlsx,check_settings()would setall_passed = Falseand fail the entire batch pre-flight check. This prevented processing the correctly configured tasks even though the extra input files are not actually an error condition.The panel title also used
bold redwhich is misleading for a non-fatal issue.Solution
all_passed = Falseassignment from the extra-files branch so that having untracked files in the input folder is a warning only and does not block batch processing.bold redtobold yellowto better reflect the non-fatal severity.Testing
Placed an extra file in
batch/inputthat is not referenced intasks_setting.xlsx. The settings check now prints a yellow warning about the extra file but continues and returnsTruewhen all configured tasks are valid.