fix(android): harden app data and cleartext defaults#15
Closed
AmirrezaFarnamTaheri wants to merge 2 commits into
Closed
fix(android): harden app data and cleartext defaults#15AmirrezaFarnamTaheri wants to merge 2 commits into
AmirrezaFarnamTaheri wants to merge 2 commits into
Conversation
Disable Android backup for sensitive VPN profile data and add explicit backup/data extraction exclusions for app databases, preferences, files, and external app storage. Deny cleartext traffic by default, remove file-scheme TOML imports from the exported import activity, and avoid showing SOCKS passwords in the Home telemetry card.
Mask common secret assignments and app-local file paths before Android/core log lines enter the UI and shareable log flows. Resolver IPs and scan counters remain visible so telemetry parsing continues to work.
Owner
|
Thank you for your effort in proposing these security hardening measures. After careful consideration, I've decided not to merge this PR. Most of the data handled by the app is not sensitive enough to justify disabling backups or restricting data extraction to this extent. Additionally, some of the stricter defaults (such as cleartext traffic restrictions and the removal of file-scheme imports) could potentially interfere with current user workflows and certain network configurations. I prefer to maintain the current balance of flexibility and functionality for now. Thank you again for your contribution and for looking out for the project's security! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable Android backup for sensitive VPN profile data and add explicit backup/data extraction exclusions for app databases, preferences, files, and external app storage.
Deny cleartext traffic by default, remove file-scheme TOML imports from the exported import activity, and avoid showing SOCKS passwords in the Home telemetry card.