refactor(Invoke-Logging): use pre-parsed scriptblock cache + add dedicated tests#77
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/HeyItsGilbert/Gatekeeper/sessions/a7d2d9f0-2833-4f10-b2d2-7e2ed8094b29 Co-authored-by: HeyItsGilbert <615265+HeyItsGilbert@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor Invoke-Logging to utilize pre-parsed script cache
refactor(Invoke-Logging): use pre-parsed scriptblock cache + add dedicated tests
May 14, 2026
Test Results 4 files 448 suites 14s ⏱️ Results for commit 86ffb8d. |
HeyItsGilbert
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invoke-Loggingwas bypassing the$script:GatekeeperLoggingcache built byImport-GatekeeperConfig, re-compiling scriptblocks from raw config on every rule evaluation — losing closure context for any scriptblock that had already been parsed.Changes
tests/Invoke-Logging.tests.ps1(new): Dedicated test coverage forInvoke-Loggingthat was previously only exercised via a mock inTest-FeatureFlag.tests.ps1. Covers:$Rulewhen the effect is enabled$script:GatekeeperLoggingis$nullor emptyImport-GatekeeperConfigis called on every invocation to guarantee cache initializationCHANGELOG.md:[Unreleased]entry documenting the fix.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
www.powershellgallery.com/usr/bin/pwsh pwsh -Command .\build.ps1 -Bootstrap(dns block)/usr/bin/pwsh pwsh -Command Register-PSRepository -Default -ErrorAction SilentlyContinue; Set-PSRepository -Name PSGallery -InstallationPolicy Trusted; .\build.ps1 -Bootstrap(dns block)/usr/bin/pwsh pwsh -Command Get-PSRepository(dns block)If you need me to access, download, or install something from one of these locations, you can either: