Handle nullable upload URI (RND-1677)#2931
Closed
hugokallstrom wants to merge 2 commits intodevelopfrom
Closed
Conversation
Backend is collapsing PartnerClaim into Claim, which loosens targetFileUploadUri from String! to String. Partner claims have no upload URI; the existing isUploadingFilesEnabled gate already hides the add-files button for them, but the type chain needs to permit null. - Schema: targetFileUploadUri: String! -> String (hand-edited; re-run downloadOctopusApolloSchemaFromIntrospection after the backend change deploys to staging to catch any unrelated drift). - ClaimDetailUiState.Content.uploadUri: String -> String? - Picker callbacks at ClaimDetailsDestination guard with ?.let so the (List<Uri>, String) -> Unit callback signature stays non-null. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The 'Uploaded files' title rendered unconditionally, even when there was no submitted content, no files, and uploads were disabled — leaving a dangling header with nothing under it. Triggered by partner claims (no audio, no free text, empty files, isUploadingFilesEnabled = false) but also affects pre-existing regular closed-non-pet claims with no submitted content. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Claim.targetFileUploadUrifromString!toStringand propagates the nullability throughClaimDetailUiState.Content.uploadUriand the picker callbacks. Companion to theclaims-servicePartnerClaim → Claim merge.Coordination
Draft until backend ships. This PR's schema edit is hand-applied to match the upcoming
claims-servicechange. Before marking ready:claims-servicePartnerClaim → Claim merge is deployed to staging../gradlew downloadOctopusApolloSchemaFromIntrospectionand confirm the diff is a no-op fortargetFileUploadUri(catches unrelated schema drift).Test plan
./gradlew :feature-claim-details:compileDebugKotlin— passes./gradlew :feature-claim-details:ktlintCheck— passesclaimsActive/claimsHistoryexternalIdshows in the display items🤖 Generated with Claude Code