Skip to content

fix:changed modals#84

Merged
dashaaaa21 merged 2 commits intodevelopfrom
FE/modalka
Feb 19, 2026
Merged

fix:changed modals#84
dashaaaa21 merged 2 commits intodevelopfrom
FE/modalka

Conversation

@dashaaaa21
Copy link
Contributor

  1. I changed modal position
    Now will be visible on teacherDetail page, user can see all information about teacher, and after need sign in when will be want do appointment
Знімок екрана 2026-02-19 о 15 00 34 Знімок екрана 2026-02-19 о 15 00 41
  1. I updated the second modal, as it was previously using the default system settings.
Знімок екрана 2026-02-19 о 15 08 17
  1. Fix: On the Teachers page, each teacher card includes a “Book” button. When the user clicks it, they are redirected to the Teacher Detail page, where the teacher card is displayed without the “Book” button.

Copilot AI review requested due to automatic review settings February 19, 2026 14:28
@HackYourFutures HackYourFutures temporarily deployed to study-bridge-fe-modalka-ubkyul February 19, 2026 14:28 Inactive
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request refactors the modal system to improve user experience by centralizing modal dialogs and changing the booking flow. Users can now view teacher details without being immediately prompted to sign in, and the booking modal is triggered when selecting a time slot. The PR also replaces native window.confirm dialogs with a custom styled confirmation modal for deletion operations.

Changes:

  • Added a reusable ConfirmDialog component and integrated it into the modal management system
  • Modified TeacherCard to conditionally show the Book button and navigate to teacher detail page instead of opening modals directly
  • Refactored booking flow in TeacherSchedule to open the booking modal immediately when a time slot is selected (after authentication check)
  • Replaced window.confirm calls with custom ConfirmDialog modal in appointment deletion flows

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
client/src/store/modals.store.ts Added confirmDelete modal type and its payload structure to the centralized modal store
client/src/components/confirmDialog/ConfirmDialog.tsx New reusable confirmation dialog component with customizable title, message, and button text
client/src/components/modalHost/modalHost.tsx Integrated the new ConfirmDialog into the modal host to render confirmDelete modals
client/src/components/teacherCard/teacherCard.tsx Added optional showBookButton prop and simplified Book button to navigate to detail page instead of opening modals
client/src/components/teacherSection/teacherSchedule/TeacherSchedule.tsx Modified to open booking modal directly when time slot is selected, after authentication check
client/src/pages/teacherDetail/teacherDetail.tsx Passed showBookButton={false} to hide the Book button on the detail page
client/src/pages/privetTeachersPages/teacherAppointments/TeacherAppointments.tsx Replaced window.confirm with ConfirmDialog modal for appointment deletions
client/src/pages/privateStudentsPages/clientsAppointments/ClientsAppointments.tsx Replaced window.confirm with ConfirmDialog modal for appointment deletions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@HackYourFutures HackYourFutures temporarily deployed to study-bridge-fe-modalka-ubkyul February 19, 2026 14:50 Inactive
@dashaaaa21 dashaaaa21 merged commit 57e6232 into develop Feb 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments