Group mount work by connection pool and use pool.with_connection#59
Merged
Conversation
Mirror Rails' fixture loading idiom: group models by connection_pool (stable identity, role-aware) instead of connection, and wrap the batch execution in pool.with_connection. Behaviorally identical inside an rspec-rails transactional fixture (with_connection yields the already-leased connection), but more correct under role switching, multi-DB, or programmatic use of mount outside a test transaction. Also stops calling model.connection multiple times per mount. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Reopens #54 — the original was auto-closed when its base branch was deleted at merge.)
Summary
Mirror Rails' fixture loading idiom in `ActiveRecordCoder#mount`:
Why
`connection_pool` is the stable identity for "this model's connection source." `model.connection` returns whatever connection the current thread/role happens to have checked out. `pool.with_connection` is the canonical lifecycle primitive — yields the leased connection if one exists, else checks out + checks in.
Behaviorally identical inside an rspec-rails transactional fixture (the test thread already has a connection leased), but more correct under role switching, multi-DB, or programmatic use of mount outside a test transaction.
Stack
Part of a stack: this is #2 of 6 (#53 already merged).
🤖 Generated with Claude Code