Skip virtual columns when generating cached fixture INSERTs#55
Merged
Conversation
This was referenced May 6, 2026
ngan
force-pushed
the
np-pool-with-connection
branch
from
7c5fcb5 to
4abd7b4
Compare
Models with generated/virtual columns reject INSERTs into those
columns ("cannot INSERT into generated column"). The coder was
including every column from model.column_names, so any model with a
t.virtual column would crash mount.
Filter columns by adapter capability + Column#virtual?, mirroring how
Rails' build_fixture_sql filters them in connection_adapters/abstract/
database_statements.rb.
Adds a computed_widgets table with a stored generated column to the
dummy app and a regression spec exercising the round-trip.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ngan
force-pushed
the
np-filter-virtual-columns
branch
from
3d65e25 to
a16df28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Filter virtual/generated columns from the cached INSERT statements built in
ActiveRecordCoder#generate_statements. Without this, any model with at.virtualcolumn crashes mount withcannot INSERT into generated column.Mirrors how Rails'
build_fixture_sqlfilters them.Repro
Adds a
computed_widgetstable to the dummy app with a stored generated column (name_upper) and a regression spec that:UPPER(name))Verified locally: without the fix, the spec fails with
SQLite3::SQLException: cannot INSERT into generated column "name_upper".Stack
Stacked on #54.
Test plan
🤖 Generated with Claude Code