fix: send responseReceived with EventSource type for SSE requests#63
Open
BAIXIONGSODA wants to merge 1 commit intoGrinZero:mainfrom
Open
fix: send responseReceived with EventSource type for SSE requests#63BAIXIONGSODA wants to merge 1 commit intoGrinZero:mainfrom
BAIXIONGSODA wants to merge 1 commit intoGrinZero:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: Fix SSE (Server-Sent Events) DevTools Display
Summary
This PR fixes the SSE request display in Chrome DevTools Network panel by sending
Network.responseReceivedwithtype: EventSourcebefore streaming SSE messages.Changes
packages/network-debugger/src/core/fetch.tsloadCallFrames()call to capture initiator stack trace for fetch requestseventSourceResponseReceivedmessage to properly notify DevTools about SSE responsespackages/network-debugger/src/fork/module/network/index.tseventSourceResponseReceivedto sendNetwork.responseReceivedwithtype: EventSourceWhy
Previously, SSE requests were not properly displayed in DevTools because the
responseReceivedevent was not sent with the correcttype: EventSource. This fix ensures:EventSourceTesting
Tested with
koa-esmapp's/sse-fetchendpoint - SSE events are now properly captured and displayed in DevTools.