Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/chains/cosmos/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
},
"dependencies": {
"@gridplus/chain-core": "workspace:*",
"@noble/hashes": "^1.8.0",
"@noble/hashes": "^2.2.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Delay noble-hashes v2 until subpath imports are updated

This upgrade introduces a breaking module-path change for @noble/hashes v2 while the code still imports v1-style paths (@noble/hashes/ripemd160 and @noble/hashes/sha256) in packages/chains/cosmos/src/chain.ts and packages/chains/xrp/src/chain.ts. With v2, those legacy subpaths are no longer compatible, so these packages can fail to build or load at runtime when address/hash code paths are executed unless the imports are migrated to the new .js subpath format.

Useful? React with 👍 / 👎.

"bech32": "^2.0.0"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/chains/xrp/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
},
"dependencies": {
"@gridplus/chain-core": "workspace:*",
"@noble/hashes": "^1.8.0",
"@noble/hashes": "^2.2.0",
"@scure/base": "^1.2.6"
},
"devDependencies": {
Expand Down
28 changes: 22 additions & 6 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading