Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/sdk/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@
"@vitest/coverage-istanbul": "^2.1.3",
"bip32": "^4.0.0",
"bip39": "^3.1.0",
"bitcoinjs-lib": "6.1.7",
"bitcoinjs-lib": "7.0.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid upgrading bitcoinjs-lib before bigint migration

Bumping bitcoinjs-lib to 7.0.1 introduces a breaking runtime API change (Transaction output values are now bigint), but this repo’s BTC test helpers still build transactions with numeric values (e.g. _start_tx_builder in packages/sdk/src/__test__/utils/helpers.ts calls tx.addOutput(..., value) and tx.addOutput(..., changeValue) where both are numbers). With this version bump, those code paths will throw during BTC signing/address tests instead of producing reference transactions, so CI/test workflows that exercise these helpers will regress until values are converted to bigint.

Useful? React with 👍 / 👎.

"bls12-381-keygen": "^0.2.4",
"dotenv": "^17.2.2",
"ecpair": "^3.0.0",
Expand Down
94 changes: 54 additions & 40 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading