Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/docs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"mdx-mermaid": "^2.0.0",
"mermaid": "^10.9.0",
"prism-react-renderer": "^2.3.1",
"react": "^18.3.1",
"react": "^19.2.5",
"react-dom": "^18.3.1"
},
"devDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions packages/example/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@
"@ethereumjs/tx": "^4.0.2",
"buffer": "^6.0.3",
"gridplus-sdk": "workspace:*",
"react": "^18.2.0",
"react": "^19.2.5",
"react-dom": "^18.2.0"
Comment on lines +17 to 18
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep react-dom major aligned with React 19 upgrade

This change upgrades react to 19.x but leaves react-dom on 18.x, creating an unsupported mixed-major pair that can trigger peer-dependency conflicts and runtime/build instability (the same mismatch is also present in packages/docs/package.json). React and React DOM are version-coupled and should be upgraded together to the same major (typically the same version line) to avoid subtle renderer/hydration breakage in the example app and docs site.

Useful? React with 👍 / 👎.

},
"devDependencies": {
"@types/react": "^18.0.26",
"@types/react": "^19.2.14",
"@types/react-dom": "^18.0.9",
"@vitejs/plugin-react": "^3.0.0",
"typescript": "^5.0.0",
Expand Down
Loading
Loading