Skip to content

Spec conformance: Section 5 — Validation#59

Merged
craigsmitham merged 5 commits intomainfrom
issue-57-spec-conformance-validation
Apr 24, 2026
Merged

Spec conformance: Section 5 — Validation#59
craigsmitham merged 5 commits intomainfrom
issue-57-spec-conformance-validation

Conversation

@craigsmitham
Copy link
Copy Markdown
Member

@craigsmitham craigsmitham commented Apr 24, 2026

Summary

Add a dedicated GraphZen.SpecConformance.Tests project with Section 5 (Validation) conformance coverage mapped to the GraphQL spec working draft.

  • 28 conformance classes covering every validation subsection (5.1.1 through 5.8.5)
  • 161 tests: 82 passing, 79 skipped with explicit gap descriptions
  • Rule-specific ExpectValid/ExpectErrors API with ToDeepEqual error assertions
  • SpecSection trait attribute with hierarchical filtering (SpecSection=5, 5.3, 5.3.3)
  • Coverage manifest + reflection-based coverage test ensuring every subsection has a class
  • Authoring guidance in test/GraphZen.SpecConformance.Tests/CLAUDE.md

Running

dotnet test test/GraphZen.SpecConformance.Tests/                             # all conformance tests
dotnet test --filter "SpecSection=5"                                          # Chapter 5
dotnet test --filter "SpecSection=5.3.3"                                      # one subsection
dotnet test --filter "FullyQualifiedName~ValidationCoverageTests"            # coverage check

Related

🤖 Generated with Claude Code

@craigsmitham craigsmitham marked this pull request as draft April 24, 2026 13:42
Replace deprecated QueryShouldPass/QueryShouldFail with ExpectValid/ExpectErrors
bound to explicit validation rules. Remove obsolete SpecValidationRuleHarness and
deprecated SpecValidation methods. Split monolithic conformance classes into
one-class-per-spec-subsection structure per authoring guidance.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@craigsmitham craigsmitham changed the title Add Section 5 spec conformance validation suite WIP: Spec conformance validation suite Apr 24, 2026
@craigsmitham craigsmitham marked this pull request as ready for review April 24, 2026 15:20
@craigsmitham craigsmitham changed the title WIP: Spec conformance validation suite Spec conformance: Section 5 — Validation Apr 24, 2026
@craigsmitham craigsmitham merged commit da9206d into main Apr 24, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant