Simplify and modernize code style configuration#56
Merged
craigsmitham merged 1 commit intomainfrom Apr 24, 2026
Merged
Conversation
- Remove ~50 redundant .editorconfig settings that match Roslyn defaults - Replace ~35 individual :suggestion severities with bulk category-Style severity - Add modern C# 10-13 style rules (primary constructors, collection expressions, etc.) - Add resharper_* settings to align JB cleanupcode with dotnet format output - Remove 14 .DotSettings inspection severities covered by .editorconfig equivalents - Remove duplicate mandatory imports already in Directory.Build.props Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #55
.editorconfigsettings matching Roslyn defaults (formatting rules, parentheses preferences, default-value code style options). Replace ~35 individual:suggestionseverities with a singledotnet_analyzer_diagnostic.category-Style.severity = suggestionbulk line, keeping only targeted overrides forwarningandsilentrules.resharper_place_field_attribute_on_same_lineandresharper_wrap_object_and_collection_initializer_styleto align JB cleanupcode output withdotnet format..DotSettingsinspection severities now covered by.editorconfigequivalents. Remove 2 duplicate mandatory imports already inDirectory.Build.props.Net result:
.editorconfigreduced from 328 to 210 lines (-36%) with no loss of enforcement.Verification
dotnet build— 0 warnings, 0 errorsdotnet format --verify-no-changes— passesdotnet build --configuration ReleasewithEnforceCodeStyleInBuild=true— 0 warningsTest plan
dotnet format→jb cleanupcode --no-builtin-settings→git diff --exit-code🤖 Generated with Claude Code