Open
Conversation
Collaborator
|
I think tests are a must. There appear to be quite a lot of settings to set with lots of opportunities for things to go wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses C config from
sysconfigby default to try to make the JIT "just work" most of the time (as long as Python knows about a C compiler).@michelp, I think you have explored using the JIT as much as anybody, so I would appreciate it if you took a careful look at this PR. Did I set everything correctly using
sysconfig? I trust you more than myself for this ;)Open questions: