fix(subscription): write reality sid to host_inbound, not the shared inbound dict#2036
Open
lsdgem wants to merge 1 commit intoGozargah:devfrom
Open
fix(subscription): write reality sid to host_inbound, not the shared inbound dict#2036lsdgem wants to merge 1 commit intoGozargah:devfrom
lsdgem wants to merge 1 commit intoGozargah:devfrom
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1986
host_inbound = inbound.copy()is taken before the host loop. the random shortId pick was writing to the originalinbound(the sharedxray.config.inbounds_by_tag[tag]), sohost_inbound["sid"]stayed unset and the URL came out with empty&sid=. moving the assignment tohost_inboundfixes it and stops mutating shared config along the way.if sids := inbound.get("sids"): - inbound["sid"] = random.choice(sids) + host_inbound["sid"] = random.choice(sids)repro: restart marzban, copy any reality user's config — first copy emits empty
sid=. refresh the page and copy again —sid=is now populated.non-reality inbounds don't have
sidsso the branch is skipped — no behavior change there.