fix(nativeHelm): support OCI repoUrl override for ORG_CHART deploys#127
Closed
vigneshrajsb wants to merge 2 commits intomainfrom
Closed
fix(nativeHelm): support OCI repoUrl override for ORG_CHART deploys#127vigneshrajsb wants to merge 2 commits intomainfrom
vigneshrajsb wants to merge 2 commits intomainfrom
Conversation
- Support OCI repoUrl override for ORG_CHART deploys - Add HELM_EXPERIMENTAL_OCI=1 to enable OCI support on helm 3.7.x - Add ECR auth init container support for OCI Helm chart deploys Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a service config specifies a custom
helm.chart.repoUrl(e.g., an OCI ECR registry), the generatedhelm upgradecommand was ignoring it for services that use the org chart (helm-app). The command would use just the bare chart name with no repo reference:Root Cause
determineChartTypereturnsChartType.ORG_CHARTwhenchartName === orgChartName && helm.dockeris set. InconstructHelmCommand, theelsebranch (which handlesORG_CHART) unconditionally used the barechartPathand never checkedchartRepoUrl:The
generateHelmInstallScriptfunction also only ranhelm repo addforChartType.PUBLIC, skippingORG_CHARTentirely.Note:
mergeChartConfigcorrectly gives service-levelrepoUrlpriority over global config — the value was properly resolved, just never used.Fix
constructHelmCommand— add OCI detection to theORG_CHARTbranch:generateHelmInstallScript— extendhelm repo addto also coverORG_CHARTwith a non-OCI customrepoUrl:After this fix, the generated command correctly uses the OCI URL as the chart reference: