Skip to content

Finalize governance widget component boundaries#52

Open
eldwin-easynet-world wants to merge 1 commit into
GoodDollar:copilot/plan-governance-homepage-componentsfrom
eldwin-easynet-world:codex/finalize-governance-widget-review
Open

Finalize governance widget component boundaries#52
eldwin-easynet-world wants to merge 1 commit into
GoodDollar:copilot/plan-governance-homepage-componentsfrom
eldwin-easynet-world:codex/finalize-governance-widget-review

Conversation

@eldwin-easynet-world

Copy link
Copy Markdown

Summary

  • Split the governance widget implementation into focused component, primitive, type, and utility modules while preserving the public exports.
  • Replaced the browser-only voter avatar <img> rendering with React Native Image, and declared the React Native / React Native Web peer/dev dependencies needed for native and Storybook web targets.
  • Kept the governance package boundary intact; no wallet, contract, subgraph, or runtime integration was added.

Validation

Run from a clean /tmp/goodwidget-income checkout with this branch patch applied:

  • corepack pnpm install --store-dir /Users/boqiang.liang/.pnpm-store
  • corepack pnpm --filter @goodwidget/storybook... build
  • STORYBOOK_DISABLE_TELEMETRY=1 corepack pnpm --filter @goodwidget/storybook build-storybook
  • pnpm test:demo tests/widgets/governance-widget — 11 passed
  • git diff --check
  • rg -n "<img|governanceComponents|from './governanceComponents'" packages/governance-widget examples/storybook/src/stories/governance-widget tests/widgets/governance-widget — no matches

Notes:

  • The first isolated @goodwidget/storybook build-storybook attempt failed until workspace dependencies such as @goodwidget/core and @goodwidget/citizen-claim-widget were built; pnpm --filter @goodwidget/storybook... build resolves that dependency-order issue.
  • Playwright initially needed a local Chromium cache fix on this machine; after the executable was available, the governance widget suite passed 11/11.

Relates to #50, #46, and #47.

@boqiang

boqiang commented Jun 13, 2026

Copy link
Copy Markdown

Closing this from my side to respect the GoodBounties assignment flow. Since #50 is assigned to @edehvictor, I don't want this PR to compete with or distract from the assigned implementation. Thanks for the clarification on the contributor process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants