Conditional unit tests for CI tests#173
Merged
Merged
Conversation
tehinator
reviewed
May 8, 2026
| let (p, stat, dof) = unwrap_correlated(&t.run_test(x, y, z, false, 0.05).unwrap()); | ||
| assert!(stat.abs() < 1e-9, "stat should be ~0, got {stat}"); | ||
| assert!(p > 0.99); | ||
| //dof = (#Z strata) * (|X|-1)(|Y|-1): 2 * 1 * 1 = 2 |
tehinator
reviewed
May 8, 2026
| let y = array![1., 2., 1., 2., 1., 2., 1., 2.]; | ||
| let z = array![[1.], [1.], [1.], [1.], [2.], [2.], [2.], [2.]]; | ||
|
|
||
| let (p, stat, dof) = unwrap_correlated(&t.run_test(x, y, z, false, 0.05).unwrap()); |
There was a problem hiding this comment.
false, 0.05 no longer needed in current version, this is wrong throughout the entire pull request
tehinator
reviewed
May 8, 2026
tehinator
left a comment
tehinator
left a comment
There was a problem hiding this comment.
Looks good, aside from the issues related to not having pulled the lastest commit from development
added 9 commits
May 8, 2026 13:22
tehinator
approved these changes
May 8, 2026
Hiddentale
approved these changes
May 15, 2026
Contributor
Hiddentale
left a comment
Hiddentale
left a comment
There was a problem hiding this comment.
Looks good :)
Modified likelihood's "cond_bool_rejects_independent" test passes successfully, but not because the test is correct.
The error is silently swallowed by power divergence's continue statement. Nevertheless, this is not something to fix for this specific task. I've added the issue for a future task.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Conditional unit tests for CI tests
Related Issues
Too many variables named a single letter. -> Solved by '#[allow(clippy::many_single_char_names)]'
Type of Change
Checklist
cargo fmt --all(code is formatted)cargo clippy --workspace --all-targets -- -D warnings(no warnings)cargo test --workspace(all tests pass)