Factory registry#152
Draft
mira-vg wants to merge 13 commits into
Draft
Conversation
- Modified ci-core registry and ci_tests/mod.rs to use closures instead of CITest instances. - Implemented PyRegistry and PyCITest. - Renamed package from 'ci-python' to 'ci_python' in Cargo.toml to allow for building. Directory name remains unchanged.
… Tests still take no arguments.
…the Rust side. TODO: Update .pyi file and implement CITestRegistry on Python side.
# Conflicts: # crates/ci-core/src/strategy.rs # crates/ci-python/Cargo.toml # crates/ci-python/src/lib.rs
…ill using the factory-ish pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Type of Change
Checklist
cargo fmt --all(code is formatted)cargo clippy --workspace --all-targets -- -D warnings(no warnings)cargo test --workspace(all tests pass)Screenshots (if applicable)
Questions for Reviewers