Refactor tide graph path method to avoid odc.geobox#1413
Merged
Conversation
Refactor tide graph path calculation to use point from map bounds.
Member
Author
|
@SpacemanPaul If you had any thoughts as to why |
vnewey
approved these changes
Mar 24, 2026
Member
Author
|
OK, this didn't fix the issue, but we do get a different error now: Seems like the |
This was referenced Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the new tide graph calculation method uses
.odc.geoboxto obtain the coordinates of the GetFeatureInfo request. Unfortunately this seems to fail, as the GetFeatureInfo returned ondatadoes not appear to have a valid GeoBox:https://ows.dev.dea.ga.gov.au/wms?service=WMS&version=1.3.0&request=GetFeatureInfo&layers=ga_s2ls_intertidal_cyear_3&query_layers=ga_s2ls_intertidal_cyear_3&styles=intertidal_elevation_adaptive&crs=EPSG:4326&bbox=-12.222735,131.869438,-12.221735,131.870438&width=101&height=101&i=50&j=50&info_format=application/json&time=2023-01-01
This PR attempts a new approach - still using the
.odcaccessor but instead using the.odc.map_bounds()method to get the extent of the data in lat/lon coordinates.