Fix missing standard library headers for independent compilation (#184)#475
Open
pacortusaez05 wants to merge 1 commit intoGeomScale:developfrom
Open
Fix missing standard library headers for independent compilation (#184)#475pacortusaez05 wants to merge 1 commit intoGeomScale:developfrom
pacortusaez05 wants to merge 1 commit intoGeomScale:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @vissarion and @elias ! I am a Math & CS undergraduate student from the University of Murcia, Spain, and I'm very interested in participating in GSoC this year, specifically for the Benchmark Polytope Import Suite project.
To get familiar with the codebase and the contribution workflow, I started working on Issue #184. I found that independent compilation fails for some headers due to missing standard library includes.
In this PR, I have added the missing includes to the following files:
Looking forward to your feedback. Let me know if you need me to change anything!