I Fixed is_in() in ball.h , which measures distance from origin(incorrect as centre keeps changing) instead of actual center.#474
Open
DhanushShetty18 wants to merge 2 commits intoGeomScale:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While studying for GSOC 2026,
I found a bug in is_in() which checks:
' p.squared_length() <= R '
This measures distance from p to the origin.
But Ball stores a center
cwhich is computedFIX :
Changed to (p - c).squared_length() <= R
This measures distance from p to the changing actual center c.
where Ball objects have non-origin centers.
Added a test case in test_internal_points.cpp that verifies
is_in works correctly with a non-origin center.
Also Verified with
full_dimensional_polytope_test
9 tests, 38 assertions, 0 failures.