Open
Conversation
Signed-off-by: Iva Janković <ivaxjankovic@gmail.com>
vissarion
reviewed
Mar 12, 2026
Member
vissarion
left a comment
vissarion
left a comment
There was a problem hiding this comment.
Please update your branch with upstream and merge conflicts to simplify the review process.
| } | ||
|
|
||
|
|
||
|
|
|
|
||
| params.facet_prev = facet; | ||
| return {min_plus, facet}; | ||
|
|
| NT* Av_data = Av.data(); | ||
| NT* sum_nom_data = sum_nom.data(); | ||
|
|
||
| for (int i = 0; i < m; ++i, ++Av_data, ++sum_nom_data) |
Member
There was a problem hiding this comment.
Why was that not here before? What is changed in this PR?
| This diagnostic assumes that P is a full-dimensional H-polytope. | ||
| The facet identification and survivor logic rely on the assumption | ||
| that each facet corresponds to a unique supporting hyperplane and that | ||
| removing one constraint locally produces a (dim-1)-dimensional facet. |
Member
There was a problem hiding this comment.
I do not understand "removing one constraint locally produces a (dim-1)-dimensional facet" Could you please explain?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scaling ratio should be fixed now, also in (billiard) shake and bake.cpp files added minESS for double checking the python binding.