Fix AppleClang 17 compliance issues in mmcs and crhmc headers#455
Open
RiyanshiTomar wants to merge 7 commits intoGeomScale:developfrom
Open
Fix AppleClang 17 compliance issues in mmcs and crhmc headers#455RiyanshiTomar wants to merge 7 commits intoGeomScale:developfrom
RiyanshiTomar wants to merge 7 commits intoGeomScale:developfrom
Conversation
…macos-with-appleclang-17 Fix AppleClang 17 compliance issues in mmcs and crhmc headers
Akash504-ai
reviewed
Feb 24, 2026
Contributor
Akash504-ai
left a comment
Akash504-ai
left a comment
There was a problem hiding this comment.
Thanks for this, the changes correctly resolve the AppleClang 17 compliance issues (#436).
…macos-with-appleclang-17-j1ka2r Use internal PRNG in QD, remove write side-effects, fix matrix inversion and template calls
vissarion
reviewed
Mar 12, 2026
…macos-with-appleclang-17-ablzuo Include <cassert> and remove unnecessary 'template' disambiguators on Walk calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solved : #436
-> Added #include to include/preprocess/crhmc/crhmc_utils.h so assert(...) is declared under strict compilers.
-> Removed the erroneous template keyword from non-template member calls in include/sampling/mmcs.hpp, replacing walk.template parameters_burnin(...) with walk.parameters_burnin(...) and walk.template get_starting_point(...) with walk.get_starting_point(...).
-> Changes are purely compile-compatibility fixes and do not alter algorithm logic or public APIs.