Skip to content

[CFM_190] chore: Update Fridge Finder REST API#134

Open
bernardm wants to merge 17 commits into
devfrom
cfm_190_bm
Open

[CFM_190] chore: Update Fridge Finder REST API#134
bernardm wants to merge 17 commits into
devfrom
cfm_190_bm

Conversation

@bernardm

Copy link
Copy Markdown
Collaborator

No description provided.

@bernardm bernardm changed the title chore: Update Fridge Finder REST API [CFM_190] chore: Update Fridge Finder REST API May 6, 2023
@bernardm

bernardm commented May 6, 2023

Copy link
Copy Markdown
Collaborator Author

Trello Card

description: Staging server (uses test data)

paths:
/v1/fridges:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the logic behind removing versioning?

@bernardm bernardm May 10, 2023

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not removed versioning. The version is in the url path of the server. It’s on line 23. I added a server field so both the dev and prod AWS lambdas can be queried directly from the Swagger Editor

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh perfect!

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's really cool :)

description: Unexpected error prevented server from fulfilling request.

/v1/fridges/{id}/reports:
/reports/last:

@1jeanpaul1 1jeanpaul1 May 10, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread src/model/data/fridge/REST.yaml

foodPercentage:
description: The percentage of food in the fridge.
foodAmount:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

foodAmount is more fitting, but this will require a data migration so I would keep it as foodPercentage for now

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants