Skip to content

feat(demo): add support for dynamic theme switching#9

Merged
paodb merged 2 commits intomasterfrom
fix-demo-styles
Mar 4, 2026
Merged

feat(demo): add support for dynamic theme switching#9
paodb merged 2 commits intomasterfrom
fix-demo-styles

Conversation

@javier-godoy
Copy link
Member

@javier-godoy javier-godoy commented Mar 3, 2026

Summary by CodeRabbit

  • New Features

    • Added dynamic theme support with automatic feature detection and initialization.
  • Style

    • Applied new styling to the upload helper demo component for improved visual presentation.

@coderabbitai
Copy link

coderabbitai bot commented Mar 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7ff6cee and 5335d46.

📒 Files selected for processing (3)
  • src/test/java/com/flowingcode/vaadin/addons/AppShellConfiguratorImpl.java
  • src/test/java/com/flowingcode/vaadin/addons/uploadhelper/UploadHelperDemoView.java
  • src/test/resources/META-INF/frontend/styles/upload-helper-demo-styles.css

Walkthrough

This pull request adds three changes across two Java source files and one CSS file. It introduces a public method override in AppShellConfiguratorImpl that configures page settings with DynamicTheme feature support, adds a CSS import annotation to UploadHelperDemoView, and introduces corresponding CSS styling rules with updated copyright information.

Changes

Cohort / File(s) Summary
AppShell Configuration
src/test/java/com/flowingcode/vaadin/addons/AppShellConfiguratorImpl.java
Added public override method configurePage(AppShellSettings) with DynamicTheme feature checking and initialization logic.
Upload Helper Styling
src/test/java/com/flowingcode/vaadin/addons/uploadhelper/UploadHelperDemoView.java, src/test/resources/META-INF/frontend/styles/upload-helper-demo-styles.css
Added CssImport annotation to UploadHelperDemoView and introduced corresponding CSS rule for vaadin-upload margin styling using theme variables.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title claims to add dynamic theme switching support, which aligns with the AppShellConfiguratorImpl changes that introduce DynamicTheme feature support.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-demo-styles

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2026

@javier-godoy javier-godoy marked this pull request as ready for review March 3, 2026 13:53
@paodb paodb merged commit d890187 into master Mar 4, 2026
4 checks passed
@paodb paodb deleted the fix-demo-styles branch March 4, 2026 20:30
@github-project-automation github-project-automation bot moved this from To Do to Pending release in Flowing Code Addons Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pending release

Development

Successfully merging this pull request may close these issues.

2 participants