Skip to content

feat: add support for Vaadin 25#8

Merged
paodb merged 4 commits intomasterfrom
vaadin25
Feb 26, 2026
Merged

feat: add support for Vaadin 25#8
paodb merged 4 commits intomasterfrom
vaadin25

Conversation

@javier-godoy
Copy link
Member

@javier-godoy javier-godoy commented Feb 26, 2026

Summary by CodeRabbit

  • Updates
    • Version bumped to 1.1.0.
    • Added support for Java 21 environment compatibility.
    • Updated core dependencies and framework versions for enhanced platform support.

@sonarqubecloud
Copy link

@javier-godoy javier-godoy marked this pull request as ready for review February 26, 2026 14:44
@javier-godoy
Copy link
Member Author

@coderabbitai full review

@coderabbitai
Copy link

coderabbitai bot commented Feb 26, 2026

✅ Actions performed

Full review triggered.

@coderabbitai
Copy link

coderabbitai bot commented Feb 26, 2026

Walkthrough

The pull request updates the project version to 1.1.0-SNAPSHOT, adds a json-migration-helper dependency, introduces a new Maven profile for Java 21 compilation with Vaadin 25.0.3, and adds an @ExtensionMethod annotation to the FileInfo class.

Changes

Cohort / File(s) Summary
Build Configuration
pom.xml
Version bumped from 1.0.2-SNAPSHOT to 1.1.0-SNAPSHOT. Dependency management property updated to version 5.2.0. New json-migration-helper dependency added. New v25 Maven profile introduced with Java 21, Vaadin 25.0.3, and Jetty 11.0.26 configuration. Note: v25 profile appears duplicated in the diff.
Class Enhancement
src/main/java/com/flowingcode/vaadin/addons/uploadhelper/FileInfo.java
@ExtensionMethod annotation added to integrate JsonMigration class functionality via Lombok extension methods. New imports: JsonMigration and ExtensionMethod.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main objective of the pull request, which is to add support for Vaadin 25.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch vaadin25

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
pom.xml (1)

86-91: Consider removing the redundant <scope>compile</scope>.

The compile scope is the default in Maven, so explicitly specifying it is unnecessary.

✨ Suggested cleanup
         <dependency>
             <groupId>com.flowingcode.vaadin</groupId>
             <artifactId>json-migration-helper</artifactId>
             <version>0.9.2</version>
-            <scope>compile</scope>
         </dependency>
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@pom.xml` around lines 86 - 91, The dependency declaration for artifactId
"json-migration-helper" (groupId "com.flowingcode.vaadin", version "0.9.2")
includes an explicit <scope>compile</scope>, which is redundant; remove the
<scope>compile</scope> element from that dependency block so the default compile
scope is used.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@pom.xml`:
- Around line 86-91: The dependency declaration for artifactId
"json-migration-helper" (groupId "com.flowingcode.vaadin", version "0.9.2")
includes an explicit <scope>compile</scope>, which is redundant; remove the
<scope>compile</scope> element from that dependency block so the default compile
scope is used.

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9bcbda8 and baaeec4.

📒 Files selected for processing (2)
  • pom.xml
  • src/main/java/com/flowingcode/vaadin/addons/uploadhelper/FileInfo.java

@paodb paodb merged commit 7ff6cee into master Feb 26, 2026
3 checks passed
@github-project-automation github-project-automation bot moved this from To Do to Pending release in Flowing Code Addons Feb 26, 2026
@paodb paodb deleted the vaadin25 branch February 26, 2026 18:35
@paodb paodb moved this from Pending release to Done in Flowing Code Addons Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants