Skip to content

feat: add polymer dependency for Vaadin 25 support#46

Merged
javier-godoy merged 8 commits intomasterfrom
issue-44
Apr 8, 2026
Merged

feat: add polymer dependency for Vaadin 25 support#46
javier-godoy merged 8 commits intomasterfrom
issue-44

Conversation

@paodb
Copy link
Copy Markdown
Member

@paodb paodb commented Apr 6, 2026

Close #44

Summary by CodeRabbit

  • Chores
    • Updated framework and build dependencies (including Vaadin) and improved dependency/version management.
    • Adjusted packaging exclusions for test artifacts.
    • Added an explicit frontend npm dependency for the timer component.
    • Added a test theme configuration file.
    • Extended copyright year range across project files.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5eb6d900-dba8-4618-875c-1753dfa8cdaa

📥 Commits

Reviewing files that changed from the base of the PR and between 9a5daf0 and f69da70.

📒 Files selected for processing (7)
  • src/main/java/com/flowingcode/vaadin/addons/simpletimer/SimpleTimer.java
  • src/test/java/com/flowingcode/addons/simpletimer/test/SerializationTest.java
  • src/test/java/com/flowingcode/vaadin/addons/DemoLayout.java
  • src/test/java/com/flowingcode/vaadin/addons/simpletimer/DemoView.java
  • src/test/java/com/flowingcode/vaadin/addons/simpletimer/SimpletimerDemo.java
  • src/test/java/com/flowingcode/vaadin/addons/simpletimer/SimpletimerDemoView.java
  • src/test/resources/META-INF/resources/frontend/styles/shared-styles.html
✅ Files skipped from review due to trivial changes (6)
  • src/test/resources/META-INF/resources/frontend/styles/shared-styles.html
  • src/test/java/com/flowingcode/vaadin/addons/simpletimer/SimpletimerDemoView.java
  • src/test/java/com/flowingcode/vaadin/addons/DemoLayout.java
  • src/test/java/com/flowingcode/vaadin/addons/simpletimer/SimpletimerDemo.java
  • src/test/java/com/flowingcode/vaadin/addons/simpletimer/DemoView.java
  • src/test/java/com/flowingcode/addons/simpletimer/test/SerializationTest.java
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/main/java/com/flowingcode/vaadin/addons/simpletimer/SimpleTimer.java

Walkthrough

This PR adds an explicit frontend npm dependency for Polymer, updates Maven properties and Vaadin profile versions, adds a test dynamic-theme properties file, and refreshes copyright headers in several test files.

Changes

Cohort / File(s) Summary
Maven configuration
pom.xml
Introduced flowingcode.commons.demo.version property with profile overrides; switched commons-demo test dependency to use the property; added **/dynamic-theme.properties exclusion in demo-jar test-jar; bumped vaadin.version to 25.1.0 and adjusted v25 profile dependencies.
Polymer/npm declaration
src/main/java/com/flowingcode/vaadin/addons/simpletimer/SimpleTimer.java
Added @NpmPackage(value = "@polymer/polymer", version = "3.5.2") annotation to declare the Polymer frontend dependency (no runtime logic changes).
Test resources
src/test/resources/META-INF/dynamic-theme.properties
Added test resource file setting theme=LUMO.
Copyright/header updates
src/test/java/com/flowingcode/addons/simpletimer/SerializationTest.java, src/test/java/com/flowingcode/vaadin/addons/DemoLayout.java, src/test/java/com/flowingcode/vaadin/addons/simpletimer/DemoView.java, src/test/java/com/flowingcode/vaadin/addons/simpletimer/SimpletimerDemo.java, src/test/java/com/flowingcode/vaadin/addons/simpletimer/SimpletimerDemoView.java, src/test/resources/META-INF/resources/frontend/styles/shared-styles.html
Updated copyright year ranges to include 2026; no functional changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Out of Scope Changes check ❓ Inconclusive While most changes align with the Vaadin 25 support objective, the PR includes several out-of-scope modifications: copyright year updates across multiple files, Maven profile changes unrelated to the polymer dependency, and a new dynamic-theme.properties file. Clarify whether copyright updates, Maven profile modifications, and the new dynamic-theme.properties file are necessary for addressing the polymer dependency issue or should be submitted as separate changes.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'feat: add polymer dependency for Vaadin 25 support' clearly and concisely summarizes the main change: adding a Polymer npm package dependency to support Vaadin 25 compatibility.
Linked Issues check ✅ Passed The PR successfully addresses issue #44 by adding the @NpmPackage annotation with @polymer/polymer 3.5.2 dependency to SimpleTimer, which resolves the Rollup import resolution error reported for Vaadin 25 builds.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue-44

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@src/test/java/com/flowingcode/addons/simpletimer/test/SerializationTest.java`:
- Line 5: The file header in SerializationTest.java contains a spacing typo
"2026Flowing" that should be "2026 Flowing"; open the top comment block in
SerializationTest.java and insert a single space between "2026" and "Flowing" so
the header matches the project's standard header formatting.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 98823a06-ec56-4b65-9116-21324d0d77fe

📥 Commits

Reviewing files that changed from the base of the PR and between 2646e27 and 9a5daf0.

📒 Files selected for processing (9)
  • pom.xml
  • src/main/java/com/flowingcode/vaadin/addons/simpletimer/SimpleTimer.java
  • src/test/java/com/flowingcode/addons/simpletimer/test/SerializationTest.java
  • src/test/java/com/flowingcode/vaadin/addons/DemoLayout.java
  • src/test/java/com/flowingcode/vaadin/addons/simpletimer/DemoView.java
  • src/test/java/com/flowingcode/vaadin/addons/simpletimer/SimpletimerDemo.java
  • src/test/java/com/flowingcode/vaadin/addons/simpletimer/SimpletimerDemoView.java
  • src/test/resources/META-INF/dynamic-theme.properties
  • src/test/resources/META-INF/resources/frontend/styles/shared-styles.html

Comment thread src/test/java/com/flowingcode/addons/simpletimer/test/SerializationTest.java Outdated
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 6, 2026

@paodb paodb requested review from javier-godoy and scardanzan April 6, 2026 21:24
@paodb paodb marked this pull request as ready for review April 6, 2026 21:25
@javier-godoy javier-godoy merged commit 0e67baf into master Apr 8, 2026
6 checks passed
@github-project-automation github-project-automation bot moved this from To Do to Pending release in Flowing Code Addons Apr 8, 2026
@javier-godoy javier-godoy deleted the issue-44 branch April 8, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pending release

Development

Successfully merging this pull request may close these issues.

Vaadin 25: error during build (failed to resolve import "@polymer/polymer/lib/legacy/polymer-fn.js)

2 participants