Skip to content

fix(demo): fix demo styles in vaadin 25#23

Merged
paodb merged 1 commit intomasterfrom
javier-godoy-patch-1
Mar 4, 2026
Merged

fix(demo): fix demo styles in vaadin 25#23
paodb merged 1 commit intomasterfrom
javier-godoy-patch-1

Conversation

@javier-godoy
Copy link
Member

@javier-godoy javier-godoy commented Mar 3, 2026

Summary by CodeRabbit

  • Style
    • Updated styling for tertiary inline button elements to reset backgrounds, borders, and shadows.
    • Enhanced icon sizing with improved fallback support for better cross-browser compatibility.

@javier-godoy javier-godoy requested review from mlopezFC and paodb March 3, 2026 16:40
@coderabbitai
Copy link

coderabbitai bot commented Mar 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8e71249 and 8f6c141.

📒 Files selected for processing (1)
  • src/test/resources/META-INF/frontend/styles/share-easy-demo-styles.css

Walkthrough

A CSS styling file was modified to add a new rule for tertiary inline buttons within a share-easy container element, resetting visual properties. Icon sizing was updated to use a fallback value of 1.25em instead of relying solely on a CSS variable.

Changes

Cohort / File(s) Summary
CSS Styling Updates
src/test/resources/META-INF/frontend/styles/share-easy-demo-styles.css
Added new CSS rule for .share-easy-container span vaadin-button[theme~="tertiary-inline"] to reset background, border, box-shadow, and vertical padding. Updated icon sizing fallback from --lumo-icon-size-s variable to explicit 1.25em value.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix(demo): fix demo styles in vaadin 25' clearly relates to the changeset, which updates CSS styles in a demo file for Vaadin 25 compatibility.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch javier-godoy-patch-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2026

@javier-godoy javier-godoy marked this pull request as ready for review March 3, 2026 16:43
@paodb paodb merged commit f5f8ea6 into master Mar 4, 2026
4 checks passed
@paodb paodb deleted the javier-godoy-patch-1 branch March 4, 2026 20:31
@github-project-automation github-project-automation bot moved this from To Do to Pending release in Flowing Code Addons Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pending release

Development

Successfully merging this pull request may close these issues.

2 participants