Skip to content

#6222 Update manifest json #6223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
martgil wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

#6222 Update manifest json #6223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e887f7
fix: update manifest.json
May 15, 2026
cbddd46
https://github.com/FlowCrypt/flowcrypt-security/issues/327
May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions extension/js/common/platform/xss.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ export class Xss {
} else if (imgHandling === 'IMG-KEEP' && checkValidURL(src)) {
// replace remote image with remote_image_container
const remoteImgEl = `
<div class="remote_image_container" data-src="${src}" data-test="remote-image-container">
<div class="remote_image_container" data-src="${Xss.escape(src)}" data-test="remote-image-container">
<span>Authenticity of this remote image cannot be verified.</span>
</div>`;
Xss.replaceElementDANGEROUSLY(img, remoteImgEl); // xss-safe-value
Expand All @@ -147,7 +147,7 @@ export class Xss {
// Handle custom containers or CID-patterned src
if ((node.classList.contains('remote_image_container') || CID_PATTERN.test(node.getAttribute('src') ?? '')) && imgHandling === 'IMG-TO-PLAIN-TEXT') {
const replacement = node.getAttribute('data-src') ?? node.getAttribute('alt') ?? '';
Xss.replaceElementDANGEROUSLY(node, replacement); // xss-safe-value
Xss.replaceElementDANGEROUSLY(node, Xss.escape(replacement)); // xss-safe-value
}

// Handle links (target and rel attributes)
Expand All @@ -171,7 +171,7 @@ export class Xss {
for (const imageContainer of imageContainerList) {
const imgUrl = imageContainer.dataset.src;
if (imgUrl) {
Xss.sanitizeAppend(imageContainer, `<img src="${imgUrl}"/>`);
Xss.sanitizeAppend(imageContainer, `<img src="${Xss.escape(imgUrl)}"/>`);
}
}
};
Expand Down
2 changes: 1 addition & 1 deletion extension/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,6 @@
],
"minimum_chrome_version": "96",
"content_security_policy": {
"extension_pages": "script-src 'self'; frame-ancestors https://mail.google.com 'self'; img-src 'self' https://* data: blob:; frame-src 'self' blob:; worker-src 'self'; form-action 'none'; media-src 'none'; font-src 'none'; manifest-src 'none'; object-src 'none'; base-uri 'self';"
"extension_pages": "script-src 'self' 'wasm-unsafe-eval'; style-src 'self' 'unsafe-inline'; img-src 'self' data: blob: https:; frame-src 'self' https://mail.google.com/ blob:; worker-src 'self'; connect-src 'self' https://*.google.com https://*.googleapis.com https://flowcrypt.com; default-src 'self'; frame-ancestors 'self' https://mail.google.com; base-uri 'self'; form-action 'self' https://accounts.google.com; font-src 'self' data:; manifest-src 'self'; object-src 'none'; media-src 'self' blob: https:; require-trusted-types-for 'script'; trusted-types default DOMPurify; upgrade-insecure-requests; block-all-mixed-content;"
}
}
Loading