Revert "feat(deploy): Add a deployment script to the server and a configurati…"#38
Closed
Fl1riX wants to merge 1 commit into
Closed
Revert "feat(deploy): Add a deployment script to the server and a configurati…"#38Fl1riX wants to merge 1 commit into
Fl1riX wants to merge 1 commit into
Conversation
…figurati…" This reverts commit 9fda4b2.
Contributor
Руководство для ревьюера (свернуто для небольших PR)Руководство для ревьюераЭтот PR откатывает ранее добавленную инфраструктуру деплоя (shell-скрипт и конфигурацию хуков) и немного очищает контекстный менеджер асинхронной DB-сессии в задаче очистки magic-токенов. Диаграмма потока для задачи очистки magic-токенов с использованием асинхронной DB-сессииflowchart TD
A[cleanup_telegram_tokens] --> B[SessionLocal async context]
B --> C[logger.info]
B --> D[db.execute delete MagicToken]
D --> E[db.commit]
B --> F[Exception handler]
F --> G[db.rollback]
Изменения по файлам
Подсказки и командыВзаимодействие с Sourcery
Настройка вашего опытаПерейдите в вашу панель управления, чтобы:
Получение помощи
Original review guide in EnglishReviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR reverts previously added deployment infrastructure (shell script and hooks configuration) and makes a small cleanup to the async DB session context manager in the magic token cleanup task. Flow diagram for magic token cleanup task using async DB sessionflowchart TD
A[cleanup_telegram_tokens] --> B[SessionLocal async context]
B --> C[logger.info]
B --> D[db.execute delete MagicToken]
D --> E[db.commit]
B --> F[Exception handler]
F --> G[db.rollback]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Привет — я оставил несколько общих замечаний:
- Дважды проверь, что
SessionLocalтеперь корректно типизирован как асинхронный контекстный менеджер после удаления# type: ignore; если статические анализаторы типов всё ещё его не распознают, подумай о добавлении или уточнении его аннотаций типов вместо повторного добавленияtype: ignore.
Подсказка для AI-агентов
Пожалуйста, обработайте комментарии из этого code review:
## Общие комментарии
- Дважды проверь, что `SessionLocal` теперь корректно типизирован как асинхронный контекстный менеджер после удаления `# type: ignore`; если статические анализаторы типов всё ещё его не распознают, подумай о добавлении или уточнении его аннотаций типов вместо повторного добавления `type: ignore`.Sourcery бесплатен для open source — если вам нравятся наши обзоры, пожалуйста, расскажите о них ✨
Original comment in English
Hey - I've left some high level feedback:
- Double-check that
SessionLocalis correctly typed as an async context manager now that the# type: ignorehas been removed; if it is still not recognized by static type checkers, consider adding or refining its type hints instead of reintroducingtype: ignore.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Double-check that `SessionLocal` is correctly typed as an async context manager now that the `# type: ignore` has been removed; if it is still not recognized by static type checkers, consider adding or refining its type hints instead of reintroducing `type: ignore`.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Coverage Report for CI Build 26872388745Coverage remained the same at 30.313%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
1 similar comment
Coverage Report for CI Build 26872388745Coverage remained the same at 30.313%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #37
Summary by Sourcery
Отменить ранее добавленные скрипты и конфигурацию деплоя и очистить незначительное игнорирование типа в задаче очистки «magic token».
Улучшения:
Деплой:
Original summary in English
Summary by Sourcery
Revert the previously added deployment scripting and configuration and clean up a minor type-ignore in the magic token cleanup task.
Enhancements:
Deployment: