Conversation
…rong impure cache usage
|
Are comments supported for constants? I didn't see this in the documentation. Comments are simply supported for packaged procedures and functions. It would make sense to do the same for constants (and any package objects, for that matter). |
No, I didn't plan to implement comments, but I think it's possible. I will take a look |
Ok, it wasn't that hard, I implemented the feature as suggested. Examples: |
| } | ||
|
|
||
| private: | ||
| CachedResource<Jrd::Constant, Jrd::RoutinePermanent> m_constant; |
There was a problem hiding this comment.
No need adding Jrd:: in this case - we are already in Jrd namespace.
AlexPeshkoff
left a comment
There was a problem hiding this comment.
Generally OK, just minor correction please
| if (ssDefiner.asBool()) | ||
| invoker = dbb->getUserId(getPermanent()->owner); | ||
|
|
||
| makeValue(tdbb, attachment, CONST.RDB$CONSTANT_BLR); |
There was a problem hiding this comment.
I'm not 100% sure - is it OK to invoke makeValue() when MINISCAN is set? Certainly, constants should not have as complex dependencies as procedures/functions, but anyway - may be better leave it for reload in such a case?
This PR adds a new database object - Package Constant (#1036). See README.packages.txt for more information.
Usage examples:
The implementation has three key points: