Skip to content

fix(providers): parse prerelease Curio versions (e.g. 1.28.2-rc1) #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
beck-8 wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −6
Draft

fix(providers): parse prerelease Curio versions (e.g. 1.28.2-rc1) #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/services/providers/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,3 @@ export const PROVIDER_FETCH_LIMIT = 100
export const VERSION_FETCH_TIMEOUT = 5_000
export const VERSION_FETCH_CONCURRENCY = 20
export const PDP_PRODUCT_TYPE = 0

export const VERSION_PATTERN =
/^\d+\.\d+\.\d+\+\w+\+git_[a-f0-9]+_\d{4}-\d{2}-\d{2}T[\d:+-]+$/
8 changes: 5 additions & 3 deletions src/services/providers/version.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
import { VERSION_FETCH_TIMEOUT, VERSION_PATTERN } from './constants'
import { parseVersionString } from '@filecoin-foundation/ui-filecoin/Table/SoftwareVersion'

import { VERSION_FETCH_TIMEOUT } from './constants'

/**
* Parse version from response text
Expand All @@ -19,10 +21,10 @@ function parseVersionFromResponse(responseText: string): string {
}

/**
* Validate version string format
* Validate a version string using the same parser as the table display and CSV.
*/
function isValidVersion(version: string): boolean {
return VERSION_PATTERN.test(version)
return parseVersionString(version) !== undefined
}
Comment on lines +24 to 28

/**
Expand Down