Skip to content

Dev#172

Merged
thibauld merged 2 commits intomainfrom
dev
Jun 12, 2025
Merged

Dev#172
thibauld merged 2 commits intomainfrom
dev

Conversation

@thibauld
Copy link
Copy Markdown
Collaborator

What?

Please describe what you're trying to accomplish in this PR.

Why?

What problem does this solve? Why is this important? What's the context?

Screenshots (optional)

@thibauld thibauld merged commit dc41716 into main Jun 12, 2025
2 of 3 checks passed
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Docker Environment Variable Syntax Error

The three newly-added -e options in the docker run command use a colon (:) instead of an equals sign (=) to assign values (e.g., VAR: '${VALUE}'). Docker's -e flag requires VAR=VALUE as a single argument. This incorrect syntax splits the argument, causing VAR: to be parsed as the environment variable name and '${VALUE}' as an unintended positional argument. This misparses the docker run command, preventing the container from starting or running without critical environment variables, which aborts the production deployment.

.github/workflows/deploy.prod.yaml#L125-L128

-e ETHERSCAN_L2_API_KEY='${ETHERSCAN_L2_API_KEY}' \
-e FAIRMINT_MAINNET_USER_ID: '${FAIRMINT_MAINNET_USER_ID}' \
-e FAIRMINT_MAINNET_PARTY_ID: '${FAIRMINT_MAINNET_PARTY_ID}' \
-e TRANSFER_AGENT_MAINNET_CLIENT_SECRET: '${TRANSFER_AGENT_MAINNET_CLIENT_SECRET}' \

Fix in Cursor


Was this report helpful? Give feedback by reacting with 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant