test(request): verify empty-body json() cache on the same request (#80)

[mvanhorn]

Summary

Fixes #80. The test "should optimize empty bodies by using the exact same memory reference" set up two separate UwsRequest instances and then invoked the module-level onDataCallback, which is overwritten by every call to _initBodyParser. Only the second request had a live callback wired up, so the test wasn't actually exercising the optimization it claimed to.

This rewrite uses a single request and calls json() twice, which is the behavior the issue suggests testing: the cache returns the same frozen sentinel on repeat calls. The empty-body path resolves through the cached EMPTY_FROZEN_OBJECT, so no onDataCallback invocation is needed.

What changed

• src/http/core/request.spec.ts: replaced the dual-request setup with a single-request test that asserts both repeat json() calls return the same frozen object.

Verification

npx jest src/http/core/request.spec.ts
# 103 tests pass

Linter passes locally.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d4d50ea9-4411-4bb3-876b-fb1cbbc07c81

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}